zabetak commented on a change in pull request #2648:
URL: https://github.com/apache/hive/pull/2648#discussion_r751178653
##########
File path: ql/pom.xml
##########
@@ -1036,26 +1036,6 @@
<goal>test-jar</goal>
</goals>
</execution>
- <execution>
- <!--this 'execution' will produce a hive-exec-$version-core.jar
which has
- all classes from ql module, i.e. the same contents as
hive-exec-$version.jar would
- have had if there was shade plugin below. The way shade was
configured since 0.13, is
- to override the default jar for ql module with the saded one but
keep the same name.
- In other words, ql modules producesd a single uber jar under the
module's coordinates,
- i.e. w/o a classifier. We also need a slim jar that only has
classes from ql. This
- jar will now be with a 'core' classifier to ensure that prior
behavior is preserved.
- It would have been better to have a slim jar called
hive-exec-$version.jar and a fat
- jar called hive-exec-$version-shaded.jar but doing this now will
cause backwards compat.
- issues-->
- <id>core-jar</id>
- <phase>package</phase>
- <goals>
- <goal>jar</goal>
- </goals>
- <configuration>
- <classifier>core</classifier>
- </configuration>
- </execution>
Review comment:
nit: Remove also line 1085/1065.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
