kgyrtkirk commented on a change in pull request #2802:
URL: https://github.com/apache/hive/pull/2802#discussion_r753099498
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryArray.java
##########
@@ -135,9 +135,9 @@ private void parse() {
// adjust arrays
adjustArraySize(arraySize);
// find out the null-bytes
- int arryByteStart = start + vInt.length;
- int nullByteCur = arryByteStart;
- int nullByteEnd = arryByteStart + (arraySize + 7) / 8;
+ int aarryByteStart = start + vInt.length;
+ int nullByteCur = aarryByteStart;
+ int nullByteEnd = aarryByteStart + (arraySize + 7) / 8;
Review comment:
```suggestion
int arrayByteStart = start + vInt.length;
int nullByteCur = arrayByteStart;
int nullByteEnd = arrayByteStart + (arraySize + 7) / 8;
```
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TimestampLocalTZTypeInfo.java
##########
@@ -45,7 +45,7 @@ public String getTypeName() {
@Override
public void setTypeName(String typeName) {
- // No need to set type name, it should always be timestamplocaltz
+ // No need to set type name, it should always be timestamplocal tz
Review comment:
```suggestion
// No need to set type name, it should always be {@link
serdeConstants.TIMESTAMPLOCALTZ_TYPE_NAME}
```
or
```suggestion
// No need to set type name, it should always be
TIMESTAMPLOCALTZ_TYPE_NAME
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
