kgyrtkirk commented on pull request #2617: URL: https://github.com/apache/hive/pull/2617#issuecomment-978022706
sqlline already seems to be pulling in some `org.jline` dependencies in the metastore-server module - so we might be already in trouble.... ``` [INFO] +- sqlline:sqlline:jar:1.9.0:compile [INFO] | +- org.jline:jline-terminal:jar:3.12.1:compile [INFO] | +- org.jline:jline-reader:jar:3.12.1:compile [INFO] | +- org.jline:jline-terminal-jansi:jar:3.12.1:compile [INFO] | | \- org.fusesource.jansi:jansi:jar:1.18:compile [INFO] | +- org.jline:jline-terminal-jna:jar:3.12.1:compile [INFO] | | \- net.java.dev.jna:jna:jar:5.3.1:compile [INFO] | \- org.jline:jline-builtins:jar:3.12.1:compile [INFO] | \- org.jline:jline-style:jar:3.12.1:compile [INFO] +- jline:jline:jar:2.14.6:compile ``` looking at a dependency:tree of master I've not seen jline deps in any hadoop-3.1.0 related artifacts however I've seen some explicit excludes for jline deps in the hadoop project - so it might be possible that the dep sneaked in during a 3rd party dep upgrade? it seem to be coming when we use hadoop-3.3.1 like this: ``` [INFO] | +- org.apache.hadoop:hadoop-yarn-client:jar:3.3.1:compile (optional) [INFO] | | +- org.eclipse.jetty.websocket:websocket-client:jar:9.4.40.v20210413:compile (optional) [INFO] | | | +- org.eclipse.jetty:jetty-client:jar:9.4.40.v20210413:compile (optional) [INFO] | | | | \- org.eclipse.jetty:jetty-http:jar:9.4.40.v20210413:compile (optional) [INFO] | | | +- org.eclipse.jetty:jetty-util:jar:9.3.27.v20190418:compile (optional) [INFO] | | | +- org.eclipse.jetty:jetty-io:jar:9.4.40.v20210413:compile (optional) [INFO] | | | \- org.eclipse.jetty.websocket:websocket-common:jar:9.4.40.v20210413:compile (optional) [INFO] | | | \- org.eclipse.jetty.websocket:websocket-api:jar:9.4.40.v20210413:compile (optional) [INFO] | | \- org.jline:jline:jar:3.9.0:compile (optional) ``` I'm not sure if hadoop is really using it...the 3.1.0 hadoop-yarn-client also haven't dragged in a jetty.websocket as a transitive dependency... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
