asolimando commented on pull request #2815: URL: https://github.com/apache/hive/pull/2815#issuecomment-979108155
There were 2 test failures: - testCliDriver[query39] – org.apache.hadoop.hive.cli.TestTezTPCDS30TBPerfCliDriver (updated but the change looks good, it's exactly our use case) - testCliDriver[udf_unix_timestamp] – org.apache.hadoop.hive.cli.TestBeeLineDriver (unrelated, passes locally, it proved flacky for me in the past this test) On top of the updated `.q.output` for `query39` I have added `TestRexNodeConverter` class for unit tests (I have added some corner cases with null/nullability and all seems in order. I had first expanded the `qtest` file with the second variant of `case when` expression (`case when a = 1` instead of `case a when 1`, where the former was already working as expected), but I have finally simplified the test as you suggested. If the tests pass and you don't have more comments I will squash the commits and upgrade the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
