pvary commented on a change in pull request #2817:
URL: https://github.com/apache/hive/pull/2817#discussion_r757256282
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -748,6 +736,7 @@ void wasSuccessful() {
* @throws Exception
*/
@Override public void close() throws Exception {
+ shutdownHeartbeater();
Review comment:
Theoretically this have the same issue as before the patch, just the
other way around. We stop the heartbeat, the transaction times out, and we try
to commit / abort.
How complicated would it be to turn off exception handling in the heart
beater instead first, and stop it after abort / commit?
Would it worth the extra complexity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
