kgyrtkirk commented on a change in pull request #2816:
URL: https://github.com/apache/hive/pull/2816#discussion_r758469294
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNullif.java
##########
@@ -86,17 +87,13 @@ public ObjectInspector initialize(ObjectInspector[]
arguments) throws UDFArgumen
public Object evaluate(DeferredObject[] arguments) throws HiveException {
Object arg0 = arguments[0].get();
Object arg1 = arguments[1].get();
- Object value0 = null;
- if (arg0 != null) {
- value0 = returnOIResolver.convertIfNecessary(arg0, argumentOIs[0],
false);
- }
+ Object value0 = returnOIResolver.convertIfNecessary(arg0, argumentOIs[0],
false);
if (arg0 == null || arg1 == null) {
return value0;
}
- PrimitiveObjectInspector compareOI = (PrimitiveObjectInspector)
returnOIResolver.get();
- if (PrimitiveObjectInspectorUtils.comparePrimitiveObjects(
- value0, compareOI,
- returnOIResolver.convertIfNecessary(arg1, argumentOIs[1], false),
compareOI)) {
+ Object value1 = returnOIResolver.convertIfNecessary(arg1, argumentOIs[1],
false);
+ ObjectInspector compareOI = returnOIResolver.get();
+ if (ObjectInspectorUtils.compare(value0, compareOI, value1, compareOI) ==
0) {
Review comment:
it does work - but there are some interesting findings:
both of the following cases change the "non-used" part of the union (note:
`create_union(idx,o0,o1)` creates a union which uses the `idx`-th object)
```
SELECT (NULLIF(create_union(0,1,2),create_union(0,1,3)) is not null);
false
SELECT (NULLIF(create_union(0,1,2),create_union(1,2,1)) is not null);
true
```
it seems like the comparision ignores the unused/dormant parts which could
be ok; but it seems like it also compares the `idx` field - I think it should
either also ignore the `idx` field or also consider the dormant objects
opened HIVE-25748 to look into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
