marton-bod commented on a change in pull request #2817:
URL: https://github.com/apache/hive/pull/2817#discussion_r759468280
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -748,6 +736,7 @@ void wasSuccessful() {
* @throws Exception
*/
@Override public void close() throws Exception {
+ shutdownHeartbeater();
Review comment:
Prior to calling commit(), we always set shouldLog=false. If the
heartbeater is on 260 after commit has happened, the hms call will still fail
but the error won't be logged on the HS2 side. However, the error would still
be logged on the HMS side, which is not ideal. Flipping the order to first shut
down the heartbeater and then commit/abort would be the only sure solution I
think to avoid the HMS-side error log too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
