pvary commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r760025563
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -3109,10 +3109,16 @@ public static TxnType getTxnType(Configuration conf,
ASTNode tree) {
if (tree.getFirstChildWithType(HiveParser.TOK_ALTERTABLE_COMPACT) != null){
return TxnType.COMPACTION;
}
+ // check if soft delete
+ if (tree.getToken().getType() == HiveParser.TOK_DROPTABLE
+ && (HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX)
+ || HiveConf.getBoolVar(conf,
ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))){
+ return TxnType.SOFT_DELETE;
Review comment:
Shall we throw an exception if we try to drop a table but the location
is not PATH_WITH_VERSION_ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
