abstractdog commented on a change in pull request #2812:
URL: https://github.com/apache/hive/pull/2812#discussion_r761878622
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
##########
@@ -1163,4 +1165,15 @@ private QueryIdentifierProto
constructQueryIdentifierProto(int dagIdentifier) {
public String getAmHostString() {
return amHost;
}
+
+ /**
+ * Overrides TezTaskCommunicatorImpl.getTotalUsedMemory in order to provide
correct aggregated memory usage.
+ * In LLAP, every container reports the whole used heap of the daemon
they're running in, so we need to consider
+ * every usedMemory once per daemon.
+ * @return
+ */
+ @Override
+ public long getTotalUsedMemory() {
+ return pingedNodeMap.values().stream().mapToLong(c -> c.usedMemory).sum();
Review comment:
also, I need to plan this consciously, because every change needs to
flow through tez DagClient API, which is protobuf based and doesn't support
map<> with the current protobuf version, so I need to find out another way to
propagate arbitrary memory-related data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
