klcopp commented on a change in pull request #2827:
URL: https://github.com/apache/hive/pull/2827#discussion_r763768080
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/MetricsConstants.java
##########
@@ -22,9 +22,13 @@
public static final String API_PREFIX = "api_";
public static final String COMPACTION_STATUS_PREFIX = "compaction_num_";
public static final String COMPACTION_OLDEST_ENQUEUE_AGE =
"compaction_oldest_enqueue_age_in_sec";
+ public static final String COMPACTION_OLDEST_WORKING_AGE =
"compaction_oldest_working_age_in_sec";
+ public static final String COMPACTION_OLDEST_CLEANING_AGE =
"compaction_oldest_cleaning_age_in_sec";
public static final String COMPACTION_INITIATOR_CYCLE =
"compaction_initiator_cycle";
+ public static final String COMPACTION_INITIATOR_DURATION =
"compaction_initiator_duration";
Review comment:
I would change this to compaction_initiator_cycle_duration in order to
be very clear; similar for compaction_cleaner_duration
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -379,6 +379,102 @@ public void markCompacted(CompactionInfo info) throws
MetaException {
}
}
+ /**
+ * Mark the cleaning start time for a particular compaction
+ *
+ * @param info info on the compaction entry
+ */
+ @Override
+ @RetrySemantics.CannotRetry
Review comment:
I'm not 100% on these, but shouldn't this have the
@RetrySemantics.ReadOnly annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
