kgyrtkirk commented on a change in pull request #2641:
URL: https://github.com/apache/hive/pull/2641#discussion_r765012114
##########
File path: storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java
##########
@@ -190,5 +191,15 @@ public void testCompareWriteIds() throws Exception {
new ValidReaderWriteIdList("default.table2", new long[] {8,10,11}, new
BitSet(), 11)),
-1);
+ ValidWriteIdList a =
Review comment:
putting a lot of cases into the same method is not really development
friendly - next time please put new testcases into new test methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
