abstractdog commented on a change in pull request #2861:
URL: https://github.com/apache/hive/pull/2861#discussion_r767574944
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java
##########
@@ -113,7 +113,7 @@ private PartitionDesc
extractSinglePartSpec(CombineHiveInputSplit hsplit) throws
for (Path path : hsplit.getPaths()) {
PartitionDesc otherPart = HiveFileFormatUtils.getFromPathRecursively(
pathToPartInfo, path, cache);
- LOG.debug("Found spec for " + path + " " + otherPart + " from " +
pathToPartInfo);
+ LOG.debug("Found spec for {} {} from {}", path, otherPart,
pathToPartInfo);
Review comment:
HIVE-16150 was doing with guards + concatenation which is 3 lines of code
here I preferred `{}` which is only 1 line and looks cleaner
so from this point of view, this is not consistent with HIVE-16150, but this
is the better way to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
