deniskuzZ commented on a change in pull request #2780:
URL: https://github.com/apache/hive/pull/2780#discussion_r770499588
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/AcidMetaDataFile.java
##########
@@ -55,7 +55,9 @@ public String toString() {
// written by Major compaction
COMPACTED,
// written by truncate
- TRUNCATED;
+ TRUNCATED,
+ // written by drop partition
+ DROPPED;
Review comment:
it's hard to be backward compatible with such a strict code. Not sure
why we need to throw an exception here. Most probably we would need to upgrade
all HMS instances.
````
String dataFormat = metaData.getOrDefault(Field.DATA_FORMAT, "null");
switch (dataFormat) {
case Value.COMPACTED:
return true;
default:
throw new IllegalArgumentException("Unexpected value for " +
Field.DATA_FORMAT
+ ": " + dataFormat);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
