pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r770592513
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -683,20 +681,17 @@ Operator genOPTree(ASTNode ast, PlannerContext
plannerCtx) throws SemanticExcept
// Wrap all other errors (Should only hit in tests)
throw new SemanticException(e);
} else {
- reAnalyzeAST = true;
+ String strategies =
conf.getVar(ConfVars.HIVE_QUERY_REEXECUTION_STRATEGIES);
+ if (strategies == null ||
!Arrays.stream(strategies.split(",")).anyMatch("recompile_without_cbo"::equals))
{
+ throw new SemanticException("Invalid configuration. If
fallbackStrategy is set to " + fallbackStrategy.name() +
+ " then " +
ConfVars.HIVE_QUERY_REEXECUTION_STRATEGIES.varname + " should contain
'recompile_without_cbo'");
Review comment:
Moved the check to `ReExecDriver.checkHookConfig` and throwing an
exception whenever the config is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
