vihangk1 commented on a change in pull request #2864:
URL: https://github.com/apache/hive/pull/2864#discussion_r770743816
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -4201,6 +4202,20 @@ public NotificationEventResponse
getNextNotification(long lastEventId, int maxEv
NotificationFilter
filter) throws TException {
NotificationEventRequest rqst = new NotificationEventRequest(lastEventId);
rqst.setMaxEvents(maxEvents);
+ return getNextNotificationsInternal(rqst, false, filter);
+ }
+
+ @Override
+ public NotificationEventResponse
getNextNotification(NotificationEventRequest request,
Review comment:
Actually adding this to the request object will not help since even if
the server does the filtering (or throwing the exception) the client API as it
is implemented currently will continue to throw the exception. We cannot change
the exiting client side API since I believe there are applications (e.g hive
replication) which rely on this behavior currently. Hence either ways I think
the change will involve client side changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
