kgyrtkirk commented on a change in pull request #2883:
URL: https://github.com/apache/hive/pull/2883#discussion_r772158224
##########
File path:
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
##########
@@ -451,7 +451,8 @@ public void close() throws HiveSQLException {
public TableSchema getResultSetSchema() throws HiveSQLException {
// Since compilation is always a blocking RPC call, and schema is ready
after compilation,
// we can return when are in the RUNNING state.
- assertState(Arrays.asList(OperationState.RUNNING,
OperationState.FINISHED));
+ assertState(Arrays.asList(OperationState.RUNNING, OperationState.FINISHED,
Review comment:
I might be coming in from the other direction - but can't we remove
`RUNNING` as well?
as a matter of fact I think this method should only be called in "final"
state - and the only final state in which this method makes sense is when the
state is `FINISHED`
from where this is being called when it causes the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
