amansinha100 commented on a change in pull request #2891:
URL: https://github.com/apache/hive/pull/2891#discussion_r772487246
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java
##########
@@ -240,6 +249,17 @@ public void process(Object row, int tag) throws
HiveException {
byte alias = (byte) tag;
List<Object> value = getFilteredValue(alias, row);
+
+ if (shortcutExtensionRows && isOuterJoinExtensionRow(tag, value)) {
+ int type = condn[0].getType();
+ if (tag == 0 && (type == JoinDesc.LEFT_OUTER_JOIN || type ==
JoinDesc.FULL_OUTER_JOIN)) {
+ emitExtensionRow(tag, value);
Review comment:
I applied this patch and added a log message to emitExtensionRow() and
ran queries with full , left and right outer join (with the extra single table
predicate in ON clause) but only see the log msg for full outer join, not for
left/right. It is unclear which situations would lead to extension rows for
left/right outer join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
