abstractdog commented on a change in pull request #2911:
URL: https://github.com/apache/hive/pull/2911#discussion_r777886508
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
##########
@@ -199,16 +199,16 @@ public static void
updateJobCredentialProviders(Configuration jobConf) {
if (credstorePassword != null) {
String execEngine = jobConf.get(ConfVars.HIVE_EXECUTION_ENGINE.varname);
- if ("mr".equalsIgnoreCase(execEngine)) {
- // if the execution engine is MR set the map/reduce env with the
credential store password
+ if ("mr".equalsIgnoreCase(execEngine) ||
"tez".equalsIgnoreCase(execEngine)) {
+ // if the execution engine is MR/Tez set the map/reduce env with the
credential store password
Collection<String> redactedProperties =
jobConf.getStringCollection(MRJobConfig.MR_JOB_REDACTED_PROPERTIES);
-
Stream.of(
JobConf.MAPRED_MAP_TASK_ENV,
JobConf.MAPRED_REDUCE_TASK_ENV,
- MRJobConfig.MR_AM_ADMIN_USER_ENV)
+ MRJobConfig.MR_AM_ADMIN_USER_ENV,
+ "tez.am.launch.env")
Review comment:
thanks @nareshpr, I'll double-check, I tested this patch on a cluster as
a POC, and I saw a simple map/reduce dag worked
also, I'm going to decide how to use this as referring to
TezConfiguration.TEZ_AM_LAUNCH_ENV, which is not visible currently in
hive-common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
