asinkovits commented on a change in pull request #2906:
URL: https://github.com/apache/hive/pull/2906#discussion_r778667658
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java
##########
@@ -101,6 +103,25 @@ public void init(AtomicBoolean stop) throws Exception {
}
}
+ @Override
+ public void setCache(CompactorMetadataCache metadataCache) {
+ this.metadataCache = metadataCache;
+ }
+
+ protected Table cacheAndResolveTable(CompactionInfo ci) throws MetaException
{
+ if (metadataCache != null) {
Review comment:
Well I was thinking this previously and because there was no default
value for the cache, I decided to allow it as null if absent. But you are right
in a sense, that using optional explicitly says that the cache can be null.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
