mbathori-cloudera commented on a change in pull request #2919:
URL: https://github.com/apache/hive/pull/2919#discussion_r781552316



##########
File path: 
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mssql.java
##########
@@ -63,7 +64,8 @@ public String getJdbcDriver() {
 
   @Override
   public String getJdbcUrl(String hostAddress) {
-    return "jdbc:sqlserver://" + hostAddress + ":1433;DatabaseName=" + HIVE_DB 
+ ";";
+    //Mssql doesn't support database parameter in docker

Review comment:
       The Mssql docker init doesn’t have database parameter for initialisation 
like postgres/mysql etc. so the initial jdbc connection should go to default 
url if the database was created with docker database 
argument.(https://github.com/microsoft/mssql-docker/issues/2)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to