deniskuzZ commented on a change in pull request #2879:
URL: https://github.com/apache/hive/pull/2879#discussion_r782198917
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3257,11 +3257,23 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
HIVE_COMPACTOR_WAIT_TIMEOUT("hive.compactor.wait.timeout", 300000L, "Time
out in "
+ "milliseconds for blocking compaction. It's value has to be higher
than 2000 milliseconds. "),
- HIVE_MR_COMPACTOR_GATHER_STATS("hive.mr.compactor.gather.stats", true, "If
set to true MAJOR compaction " +
+ /**
+ * @deprecated This config value is honoured by the MR based compaction
only.
+ * Use the {@link HiveConf.ConfVars#HIVE_COMPACTOR_GATHER_STATS}
+ * config instead which is honoured by both the MR and Query based
compaction.
+ */
+ @Deprecated
+ HIVE_MR_COMPACTOR_GATHER_STATS("hive.mr.compactor.gather.stats", false,
"If set to true MAJOR compaction " +
"will gather stats if there are stats already associated with the
table/partition.\n" +
"Turn this off to save some resources and the stats are not used
anyway.\n" +
"Works only for MR based compaction, CRUD based compaction uses
hive.stats.autogather."),
+ HIVE_COMPACTOR_GATHER_STATS("hive.compactor.gather.stats", true, "If set
to true MAJOR compaction " +
Review comment:
Do we re-calculate stats only in case of MAJOR compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
