klcopp commented on a change in pull request #2916:
URL: https://github.com/apache/hive/pull/2916#discussion_r789465573
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -412,7 +421,11 @@ private boolean removeFiles(String location,
ValidWriteIdList writeIdList, Compa
}
StringBuilder extraDebugInfo = new
StringBuilder("[").append(obsoleteDirs.stream()
.map(Path::getName).collect(Collectors.joining(",")));
- return remove(location, ci, obsoleteDirs, true, fs, extraDebugInfo);
+ boolean success = remove(location, ci, obsoleteDirs, true, fs,
extraDebugInfo);
+ if (dir.getObsolete().size() > 0) {
+ updateDeltaFilesMetrics(ci.dbname, ci.tableName, ci.partName,
obsoleteDirs);
Review comment:
I regret suggesting that we include aborted directories in the obsolete
count.
1. There are other metrics about aborted directories.
2. previouslyActiveDeltas - (obsolete + aborted) != currentlyActiveDeltas,
so the active delta count would be off.
My bad :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
