lcspinter commented on a change in pull request #2973:
URL: https://github.com/apache/hive/pull/2973#discussion_r792724777
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1600,7 +1602,9 @@ public static ConfVars getMetaConf(String name) {
// Deprecated Hive values that we are keeping for backwards compatibility.
@Deprecated
HIVE_CODAHALE_METRICS_REPORTER_CLASSES("hive.service.metrics.codahale.reporter.classes",
- "hive.service.metrics.codahale.reporter.classes", "",
+ "hive.service.metrics.codahale.reporter.classes",
+
"org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
+ "org.apache.hadoop.hive.common.metrics.metrics2.JmxMetricsReporter",
Review comment:
This param is used to initialize the CodahaleMetricsReporter classes. In
some unit test, we are using it, and since the unit test were moved from the
`hive-common` module to the `standalone-metastore-common` module, I had to add
these values to the `MetastoreConf` to keep backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
