kasakrisz commented on a change in pull request #2984:
URL: https://github.com/apache/hive/pull/2984#discussion_r795383568
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
##########
@@ -97,23 +98,83 @@
private static final Logger LOG =
LoggerFactory.getLogger(HiveMaterializedViewsRegistry.class);
private static final String CLASS_NAME =
HiveMaterializedViewsRegistry.class.getName();
- /* Singleton */
- private static final HiveMaterializedViewsRegistry SINGLETON = new
HiveMaterializedViewsRegistry();
+ /**
+ * Registry for materialized views. The goal of this cache is to avoid
parsing and creating
+ * logical plans for the materialized views at query runtime. When a query
arrives, we will
+ * just need to consult this cache and extract the logical plans for the
views (which had
+ * already been parsed) from it. This cache lives in HS2.
+ */
+ public interface MaterializedViewsRegistry {
Review comment:
The intention was to extract the Dummy and Default implementations to
separate classes. The `MaterializedViewsRegistry` interface is the common
interface of the two implementations. Moved it to a separate file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
