deniskuzZ commented on a change in pull request #2981:
URL: https://github.com/apache/hive/pull/2981#discussion_r796522231
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -339,15 +326,19 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
CompactionInfo ci = null;
boolean computeStats = false;
Table t1 = null;
- try (CompactionTxn compactionTxn = new CompactionTxn()) {
- if (msc == null) {
- try {
- msc = HiveMetaStoreUtils.getHiveMetastoreClient(conf);
- } catch (Exception e) {
- LOG.error("Failed to connect to HMS", e);
- return false;
- }
+
+ // If an exception is thrown in the try-with-resources block below, msc is
closed and nulled, so a new instance
+ // is need to be obtained here.
+ if (msc == null) {
+ try {
+ msc = HiveMetaStoreUtils.getHiveMetastoreClient(conf);
+ } catch (Exception e) {
+ LOG.error("Failed to connect to HMS", e);
+ return false;
Review comment:
shouldn't we throw an exception here? that would allow to simplify the
code
````
msc =
Optional.ofNullable(msc).orElse(HiveMetaStoreUtils.getHiveMetastoreClient(conf));
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
