asolimando commented on a change in pull request #2966:
URL: https://github.com/apache/hive/pull/2966#discussion_r798348894
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInBetweenExpandRule.java
##########
@@ -138,7 +138,7 @@ public void onMatch(RelOptRuleCall call) {
private final RexBuilder rexBuilder;
private boolean modified;
- private RexInBetweenExpander(RexBuilder rexBuilder) {
+ RexInBetweenExpander(RexBuilder rexBuilder) {
Review comment:
TLDR: Sorry, that's just a leftover from a previous attempt.
Long story:
At some point I attempted to expand `IN` to check the impact on
simplification, but there were more side-effects than benefits, I have dropped
that part but forgot to put the original visibility back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
