zabetak opened a new pull request #3007:
URL: https://github.com/apache/hive/pull/3007


   ### What changes were proposed in this pull request?
   1. Refactor code handling remaining batches to use 
`GetPartitionsByNamesRequest` and 
`getPartitionsByNames(GetPartitionsByNamesRequest,Table)` method
   2. Use method parameter to determine if column stats must be fetched instead 
of harcoding the value to false when sending the request to HMS.
   3. Remove redundant exception wrapping
   4. Unify batch creation/execution logic using Guava's Lists#partition method.
   5. Drop unused requests from TestHiveMetaStoreClientApiArgumentsChecker
   6. Add tests for getPartitionsByName with non-empty partition name lists
   
   ### Why are the changes needed?
   1. The write id list & table id are not set when the number of names is not 
an exact multiple of the batch size which can have an impact in the consistency 
of the cache.
   2. Column stats for partitions are always missing since the request was 
hardcoded to false.
   3. Improve code readability and remove duplicated fragments.
   
   ### Does this PR introduce _any_ user-facing change?
   Fixes the bugs.
   
   ### How was this patch tested?
   `mvn test -Dtest=TestHiveMetaStoreClientApiArgumentsChecker`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to