baifachuan commented on pull request #2987: URL: https://github.com/apache/hive/pull/2987#issuecomment-1033417977
> Maybe an overkill, but shall we create a test which makes sure that the method is not removed from the create table path? > > Maybe something like this: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java#L341 Thanks for your reply. I think this feature only adds a verification for the storage location, its compatibility with other tests. I make sure to create fail when the location is ROOT path and make sure other tests pass. So I add two tests to verify the ROOT path and not the ROOT path. TestTablesCreateDropAlterTruncate.java tests maybe like an E2E test. I will consider adding a test for this case. thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
