abstractdog commented on a change in pull request #3019:
URL: https://github.com/apache/hive/pull/3019#discussion_r806738235
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -7002,6 +7018,16 @@ public void stripHiddenConfigurations(Configuration
conf) {
HiveConfUtil.stripConfigurations(conf, hiddenSet);
}
+ /**
+ * Strips hidden config entries from configuration, but takes care of
entries for execution engines.
+ */
+ public void stripHiddenConfigurationsForExecutionEngines(Configuration conf)
{
+ Set<String> propsToBePropagatedToExecEngines =
HiveConfUtil.getPropagateToExecutionEnginesList(conf);
+ Set<String> propsToBeStripped = new HashSet<String>(hiddenSet);
Review comment:
done
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
##########
@@ -84,12 +84,18 @@ public static StringBuilder dumpConfig(HiveConf conf) {
* @return The list of the configuration values to hide
*/
public static Set<String> getHiddenSet(Configuration configuration) {
+ return getConfigurationKeyset(configuration,
HiveConf.ConfVars.HIVE_CONF_HIDDEN_LIST);
+ }
+
+ public static Set<String> getPropagateToExecutionEnginesList(Configuration
configuration) {
+ return getConfigurationKeyset(configuration,
HiveConf.ConfVars.HIVE_CONF_PROPAGATE_EXEC_ENGINES);
+ }
+
+ private static Set<String> getConfigurationKeyset(Configuration
configuration, ConfVars name) {
Set<String> hiddenSet = new HashSet<String>();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
