pvary commented on a change in pull request #3052:
URL: https://github.com/apache/hive/pull/3052#discussion_r814635583
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13131,7 +13131,8 @@ public void validate() throws SemanticException {
LOG.debug("validated " + usedp.getName());
LOG.debug(usedp.getTable().getTableName());
WriteEntity.WriteType writeType = writeEntity.getWriteType();
- if (writeType != WriteType.UPDATE && writeType != WriteType.DELETE) {
+ if (writeType != WriteType.UPDATE && writeType != WriteType.DELETE
&& writeType != WriteType.DDL_NO_LOCK
Review comment:
Yeah, checking `AcidUtils.isTransactionalTable(tbl)` seems more
reasonable than depending on the `WriteType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
