szlta commented on a change in pull request #3060:
URL: https://github.com/apache/hive/pull/3060#discussion_r818465847
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergOutputCommitter.java
##########
@@ -77,7 +77,7 @@
);
private static final PartitionSpec PARTITIONED_SPEC =
- PartitionSpec.builderFor(CUSTOMER_SCHEMA).bucket("customer_id",
3).build();
+
PartitionSpec.builderFor(CUSTOMER_SCHEMA).identity("customer_id").build();
Review comment:
Most of the write path is mocked out, Hive queries are not committed to
test writes in this test class. That means no optimizers can run either, and
thus the result set before a write would not be sorted by bucket function. With
the absence of lenient ClusteredWriter this would make the test always fail for
partitioned writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
