veghlaci05 commented on a change in pull request #3034:
URL: https://github.com/apache/hive/pull/3034#discussion_r818536645
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3318,6 +3318,10 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
HIVE_COMPACTOR_CLEANER_RETENTION_TIME("hive.compactor.cleaner.retention.time.seconds",
"300s",
new TimeValidator(TimeUnit.SECONDS), "Time to wait before cleanup of
obsolete files/dirs after compaction. \n"
+ "This is the minimum amount of time the system will wait, since it
will not clean before all open transactions are committed, that were opened
before the compaction"),
+
HIVE_COMPACTOR_CLEANER_MAX_RETRY_ATTEMPTS("hive.compactor.cleaner.retry.maxattempts",
5,
+ new RangeValidator(0, 10), "Maximum number of attempts to clean a
table again after a " +
+ "failed cycle. The delay has a backoff, and calculated the
following way: " +
+ "pow(2, number_of_failed_attempts) *
HIVE_COMPACTOR_CLEANER_RETENTION_TIME. Must be between 0 and 10"),
Review comment:
Separating retry retention time from the delayed start retention time
makes sense. However I would keep the backoff algorithm to wait more and more
time before retrying failed clean attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
