pvary commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r820594561



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4151,16 +4152,18 @@ public boolean dropPartition(String dbName, String 
tableName, List<String> parti
       }
 
       if (nParts > nBatches * batchSize) {
-       String validWriteIdList = null;
-       Long tableId = null;
-       if (AcidUtils.isTransactionalTable(tbl)) {
-        ValidWriteIdList vWriteIdList = getValidWriteIdList(tbl.getDbName(), 
tbl.getTableName());
-        validWriteIdList = vWriteIdList != null ? vWriteIdList.toString() : 
null;
-        tableId = tbl.getTTable().getId();
-      }
+        String validWriteIdList = null;

Review comment:
       We need to push down the `vaildWriteIdList` and the `tableId`, so if 
there is caching in the catalog side then we the cache could be refreshed when 
needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to