deniskuzZ commented on a change in pull request #2971:
URL: https://github.com/apache/hive/pull/2971#discussion_r825828027
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java
##########
@@ -271,6 +273,11 @@ protected void addLegacyFile(Table t, Partition p, int
numRecords) throws Except
addFile(t, p, 0, 0, numRecords, FileType.LEGACY, 2, true);
}
+ protected void addDeltaFile(Table t, Partition p, long minTxn, long maxTxn,
int numRecords,
+ long visibilityId) throws Exception {
+ addFile(t, p, minTxn, maxTxn, numRecords, FileType.DELTA, 2, true,
visibilityId);
Review comment:
this change has 0 effect, as it visibilityId is not used in delta file
creation. Should be
````
case DELTA: filename = AcidUtils.addVisibilitySuffix(
makeDeltaDirName(minTxn, maxTxn),
visibilityId);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
