pvary commented on pull request #3094: URL: https://github.com/apache/hive/pull/3094#issuecomment-1067251117
@rbalamohan: The commit causes multiple tests to fail. ``` Testing / split-11 / PostProcess / testSchemaEvolutionOnVectorizedReads[fileFormat=PARQUET, engine=tez, catalog=HIVE_CATALOG, isVectorized=true] – org.apache.iceberg.mr.hive.TestHiveIcebergSchemaEvolution 8s Testing / split-16 / PostProcess / testPartitionPruning[fileFormat=PARQUET, engine=tez, catalog=HIVE_CATALOG, isVectorized=true] – org.apache.iceberg.mr.hive.TestHiveIcebergPartitions ``` I think the decision was that we should not commit changes with failing tests, precisely to avoid this kind of situation. `enforce_constraint_notnull` is failing because of the erroneous merging of #3040, but I was unable to get a green run to confirm this, because in the meantime this change is merged as well which caused even more failing tests. 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
