zabetak commented on a change in pull request #3095:
URL: https://github.com/apache/hive/pull/3095#discussion_r828058065
##########
File path: ql/pom.xml
##########
@@ -1072,6 +1072,7 @@
<artifactSet>
<includes>
<!-- order is meant to be the same as the ant build -->
+ <include>org.antlr:antlr-runtime</include>
Review comment:
I run `for f in *.jar; do echo $f; jar tf $f | grep CommonTree; done` on
the lib folder (for both 3.1.2 and master) and I see the following:
**Hive 3.1.2**
```
antlr-runtime-3.5.2.jar
org/antlr/runtime/tree/CommonTree.class
org/antlr/runtime/tree/CommonTreeAdaptor.class
org/antlr/runtime/tree/CommonTreeNodeStream.class
...
hive-druid-handler-3.1.2.jar
org/antlr/runtime/tree/CommonTree.class
org/antlr/runtime/tree/CommonTreeAdaptor.class
org/antlr/runtime/tree/CommonTreeNodeStream.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTree.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTreeAdaptor.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTreeNodeStream.class
```
**master**
```
antlr-runtime-3.5.2.jar
org/antlr/runtime/tree/CommonTree.class
org/antlr/runtime/tree/CommonTreeAdaptor.class
org/antlr/runtime/tree/CommonTreeNodeStream.class
...
hive-druid-handler-4.0.0-SNAPSHOT.jar
org/antlr/runtime/tree/CommonTree.class
org/antlr/runtime/tree/CommonTreeAdaptor.class
org/antlr/runtime/tree/CommonTreeNodeStream.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTree.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTreeAdaptor.class
org/skife/jdbi/org/antlr/runtime/tree/CommonTreeNodeStream.class
...
hive-exec-4.0.0-SNAPSHOT.jar
org/antlr/runtime/tree/CommonTree.class
org/antlr/runtime/tree/CommonTreeAdaptor.class
org/antlr/runtime/tree/CommonTreeNodeStream.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
