sourabh912 commented on a change in pull request #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r832508524
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1356,6 +1356,13 @@ public static ConfVars getMetaConf(String name) {
"Comma-separated list of tasks that will be started in separate
threads. These will be" +
" started only when the metastore is running as a separate
service. They must " +
"implement " + METASTORE_TASK_THREAD_CLASS),
+ THRIFT_TRANSPORT_MODE("metastore.server.thrift.transport.mode",
+ "hive.metastore.server.thrift.transport.mode", "binary",
+ "Transport mode for thrift server in Metastore. Can be binary or
http"),
+ THRIFT_HTTP_PATH("metastore.server.thrift.http.path",
Review comment:
I think a better config name would be
`metastore.server.thrift.transport.http.path`. Thoughts?
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java
##########
@@ -271,6 +286,31 @@ public static TTransport getSSLSocket(String host, int
port, int loginTimeout,
return getSSLSocketWithHttps(tSSLSocket);
}
+ public static THttpClient getHttpSSLSocket(String httpsUrl, String
trustStorePath,
+ String trustStorePasswd, String trustStoreAlgorithm, String
trustStoreType)
Review comment:
The server side code for this is in HiveMetaStore.java at
https://github.com/apache/hive/pull/3105/files#diff-00e70b6958060aa36762b21bf16676f83af01c1e09b56816aecc6abe7c8ac866R683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
