zabetak commented on a change in pull request #3141:
URL: https://github.com/apache/hive/pull/3141#discussion_r834397936
##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -41,6 +41,12 @@
<exclude>**/.project</exclude>
<exclude>**/.settings/**</exclude>
<exclude>**/thirdparty/**</exclude>
+
<exclude>standalone-metastore/metastore-common/src/gen/version/**</exclude>
+ <exclude>standalone-metastore/metastore-server/src/gen/**</exclude>
+ <exclude>common/src/gen/**</exclude>
+ <exclude>kafka-handler/src/test/gen/**</exclude>
+ <exclude>conf/hive-default.xml.template</exclude>
+ <exclude>ql/dependency-reduced-pom.xml</exclude>
Review comment:
Can we make the exclusions (or some of them) more generic to avoid
including again similar things in the future? For instance exclude all kind of
dependency-reduced-pom.xml files and not only under ql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
