zabetak commented on a change in pull request #3139:
URL: https://github.com/apache/hive/pull/3139#discussion_r835211948
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
I don't think this is necessary. First it is not going to be replaced
like that and second it is used in conjunction with an in-memory derby so no DB
file is created in the file-system.
##########
File path: standalone-metastore/metastore-server/pom.xml
##########
@@ -573,6 +573,9 @@
<java.io.tmpdir>${test.tmp.dir}</java.io.tmpdir>
<test.tmp.dir>${test.tmp.dir}</test.tmp.dir>
<hive.in.test>true</hive.in.test>
+ <derby.version>${derby.version}</derby.version>
+
<derby.stream.error.file>${test.tmp.dir}/derby.log</derby.stream.error.file>
+
<javax.jdo.option.ConnectionURL>jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true</javax.jdo.option.ConnectionURL>
Review comment:
This is a `MetastoreConf` property, it doesn't feel right to put it
here. Also, I am not sure if every test should use an Derby database and
specifically in-memory. Why is this change needed?
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
https://db.apache.org/derby/docs/10.8/devguide/cdevdvlp17453.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
