pvary commented on a change in pull request #3147:
URL: https://github.com/apache/hive/pull/3147#discussion_r837233568
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java
##########
@@ -299,12 +300,14 @@ public static void validateDataWithSQL(TestHiveShell
shell, String tableName, Li
Assert.assertEquals(record.size(), row.length);
for (int j = 0; j < record.size(); ++j) {
Object field = record.get(j);
- if (field instanceof LocalDateTime) {
+ if (field == null) {
+ Assert.assertNull(row[j]);
+ } else if (field instanceof LocalDateTime) {
Assert.assertEquals(((LocalDateTime)
field).toInstant(ZoneOffset.UTC).toEpochMilli(),
TimestampUtils.stringToTimestamp((String)
row[j]).toEpochMilli());
} else if (field instanceof OffsetDateTime) {
Assert.assertEquals(((OffsetDateTime)
field).toInstant().toEpochMilli(),
- TimestampTZUtil.parse((String) row[j]).toEpochMilli());
+ TimestampTZUtil.parse((String) row[j],
ZoneId.systemDefault()).toEpochMilli());
Review comment:
Yeah. Without that, if the string does not contain the TZ, then
`TimestampTZUtil.parse` does not know which TZ it should use in parsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
