marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r842857047
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -118,18 +120,23 @@ public void commitTask(TaskAttemptContext
originalContext) throws IOException {
.run(output -> {
Table table =
HiveIcebergStorageHandler.table(context.getJobConf(), output);
if (table != null) {
- HiveIcebergRecordWriter writer = writers.get(output);
- DataFile[] closedFiles;
+ HiveIcebergWriter writer = writers.get(output);
+ HiveIcebergWriter delWriter = delWriters.get(output);
+ String fileForCommitLocation =
generateFileForCommitLocation(table.location(), jobConf,
+ attemptID.getJobID(), attemptID.getTaskID().getId());
+ if (delWriter != null) {
+ DeleteFile[] closedFiles = delWriter.deleteFiles().toArray(new
DeleteFile[0]);
+ createFileForCommit(closedFiles, fileForCommitLocation,
table.io());
Review Comment:
We could write into a single forCommit, but it would complicate things
during the jobCommit operation. We'd have to read the files back from disk and
check for each file separately whether it's a DataFile or a DeleteFile, since
they each need a different Iceberg API call to commit them (`table.newAppend()`
vs `table.newRowDelta()`, respcetively)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
