klcopp commented on code in PR #3177:
URL: https://github.com/apache/hive/pull/3177#discussion_r842981037
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -320,10 +320,19 @@ private boolean
foundCurrentOrFailedCompactions(ShowCompactResponse compactions,
if (compactions.getCompacts() == null) {
return false;
}
+
+ //In case of an aborted Dynamic partition insert, the created entry in the
compaction queue does not contain
+ //a partition name even for partitioned tables. As a result it can happen
that the ShowCompactResponse contains
+ //an element without partition name for partitioned tables. Therefore, it
is necessary to check the partition name of
Review Comment:
I have to say I got confused here. For people like me this would be better:
> Therefore, it is necessary to check
we could have:
> Therefore, it is necessary to null check
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -320,10 +320,19 @@ private boolean
foundCurrentOrFailedCompactions(ShowCompactResponse compactions,
if (compactions.getCompacts() == null) {
return false;
}
+
+ //In case of an aborted Dynamic partition insert, the created entry in the
compaction queue does not contain
+ //a partition name even for partitioned tables. As a result it can happen
that the ShowCompactResponse contains
+ //an element without partition name for partitioned tables. Therefore, it
is necessary to check the partition name of
Review Comment:
I have to say I got confused here. For people like me this would be better:
> Therefore, it is necessary to check
we could have:
> Therefore, it is necessary to null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
