marton-bod commented on code in PR #3131: URL: https://github.com/apache/hive/pull/3131#discussion_r844076945
########## iceberg/iceberg-handler/src/test/queries/negative/delete_iceberg_vectorized.q: ########## @@ -0,0 +1,10 @@ +set hive.vectorized.execution.enabled=true; +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; Review Comment: We get an exception here if the txn handler does not support acid operations: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java#L70 It crossed my mind whether to disable this check for Iceberg, but it didn't seem worth the effort, since we only have the ASTTree available in this method so the parsing might be complicated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
