kasakrisz commented on code in PR #3179:
URL: https://github.com/apache/hive/pull/3179#discussion_r845281998


##########
ql/src/test/results/clientnegative/joinneg.q.out:
##########
@@ -1 +1 @@
-FAILED: SemanticException [Error 10004]: Line 6:12 Invalid table alias or 
column reference 'b': (possible column names are: x.key, x.value, y.key, 
y.value)
+FAILED: SemanticException [Error 10009]: Line 6:12 Invalid table alias 'b'

Review Comment:
   The original error message was more informative.



##########
ql/src/test/results/clientpositive/llap/views_explain_ddl.q.out:
##########
@@ -305,7 +305,7 @@ TBLPROPERTIES (
 ALTER TABLE db1.table2_n13 UPDATE STATISTICS 
SET('numRows'='0','rawDataSize'='0' );
 ALTER TABLE db1.table1_n19 UPDATE STATISTICS 
SET('numRows'='0','rawDataSize'='0' );
 
-CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k` 
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON `t1`.`key` = 
`t2`.`key`;
+CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k` 
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON t1.key = t2.key;

Review Comment:
   View expanded text changed: quotation removed from table and column names in 
join condition: 
   ```
   t1.key = t2.key
   ```
   should remain 
   ```
   `t1`.`key` = `t2`.`key`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to