zabetak commented on code in PR #3168:
URL: https://github.com/apache/hive/pull/3168#discussion_r845912230
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -474,23 +474,6 @@
</target>
</configuration>
</execution>
- <execution>
- <id>generate-version-annotation</id>
- <phase>generate-sources</phase>
- <configuration>
- <target>
- <exec executable="bash" failonerror="true">
- <arg value="${basedir}/src/main/resources/saveVersion.sh"/>
- <arg value="${project.version}"/>
- <arg value="${hive.version.shortname}"/>
- <arg value="${basedir}/src"/>
- </exec>
- </target>
- </configuration>
- <goals>
- <goal>run</goal>
- </goals>
- </execution>
Review Comment:
I looked a bit more on the history of things and my understanding is that
this `saveVersion.sh` script along with the generated package information are
necessary so that `org.apache.hadoop.hive.metastore.utils.MetastoreVersionInfo`
runs correctly.
From what I can see the
`org.apache.hadoop.hive.metastore.utils.MetastoreVersionInfo` class is in
metastore-server module and you chose to remove the generated package info from
this module. Did you verify if it still runs correctly?
I was expecting that
`org.apache.hadoop.hive.metastore.utils.MetastoreVersionInfo`,
`saveVersion.sh`, etc. should all be in the same module and `metastore-common`
seems more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
