marton-bod commented on code in PR #3202:
URL: https://github.com/apache/hive/pull/3202#discussion_r848449913
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergInserts.java:
##########
@@ -183,6 +183,22 @@ public void
testInsertOverwriteBucketPartitionedTableThrowsError() {
testTables.getInsertQuery(HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS,
target, true)));
}
+ @Test
+ public void testInsertOverwriteWithPartitionEvolutionThrowsError() throws
IOException {
Review Comment:
It would be great to have a test where we:
- create table and insert data
- evolve partition spec
- insert more data
- try IOW -> fails
- rewrite old data files
- try IOW -> succeeds
Right now we don't have the tools for this, because rewriting the old data
will be best achieved using the MERGE statement - so in the meantime, can we
insert a TODO line to add some testing for this once MERGE is available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
