kgyrtkirk opened a new pull request, #3205:
URL: https://github.com/apache/hive/pull/3205
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
restricts the optimization to only happen in case `X IS NULL` is present and
`X` is Strong and there is no `CAST` in `X`.
...in fact in Hive `CAST` is not `Strong`; but its not possible to change
how `CAST` is treated in the current version of Calcite
### Why are the changes needed?
without this patch incorrect optimaztion may happen
### Does this PR introduce _any_ user-facing change?
not really - it only makes the optimization less zealous
### How was this patch tested?
a qtest was added to cover for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
