maheshk114 commented on code in PR #3170:
URL: https://github.com/apache/hive/pull/3170#discussion_r850018398
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5215,7 +5215,7 @@ private static void moveAcidFiles(String deltaFileType,
PathFilter pathFilter, F
bucketDest.toUri().toString());
try {
fs.rename(bucketSrc, bucketDest);
- if (newFiles != null) {
+ if (newFiles != null && !newFiles.contains(bucketDest)) {
Review Comment:
"Task reattempt generates more than one temporary files" ..this
de-duplication should be done in file sink itself. In this case the second
move/rename will fail. And that will cause data correctness issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
