asolimando commented on code in PR #2966:
URL: https://github.com/apache/hive/pull/2966#discussion_r857758546
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java:
##########
@@ -1214,6 +1214,58 @@ public FixNullabilityShuttle(RexBuilder rexBuilder,
}
}
+ /**
+ * Find disjunction (OR) in an expression (at any level of nesting).
+ *
+ * Example 1: OR(=($0, $1), IS NOT NULL($2))):INTEGER (OR in the top-level
expression)
+ * Example 2: NOT(AND(=($0, $1), IS NOT NULL($2))
+ * this is equivalent to OR((<>($0, $1), IS NULL($2))
+ * Example 3: AND(OR(=($0, $1), IS NOT NULL($2)))) (OR in inner expression)
+ */
Review Comment:
> I had in mind compiling with -Pjavadoc profile and checking for new errors
in this class. Actually I am afraid of <> symbols as well as $. Don't remember
if it is fine to use them like that.
Indeed '<' and '>' are illegal, the rest did not highlight any issue when
compiling with `-Pjavadoc`. I took the chance to improve the formatting of the
list of examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
