zabetak commented on code in PR #3246:
URL: https://github.com/apache/hive/pull/3246#discussion_r859794193


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -2107,7 +2108,10 @@ private boolean 
isMaterializedViewRewritingByTextEnabled() {
     }
 
     private RelNode applyMaterializedViewRewritingByText(
-            ASTNode queryToRewriteAST, RelNode originalPlan, RelOptCluster 
optCluster) {
+            ASTNode queryToRewriteAST,
+            RelNode originalPlan,
+            RelOptCluster optCluster,
+            RelMetadataProvider metadataProvider) {

Review Comment:
   Is it necessary to add new `metadataProvider` parameter? Does 
`optCluster.getMetadataProvider()` return a different provider from the one 
passed as parameter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to